imapnotify: added in all-packages.nix#42389
Merged
matthewbauer merged 2 commits intoNixOS:masterfrom Jun 22, 2018
tobiasBora:master
Merged
imapnotify: added in all-packages.nix#42389matthewbauer merged 2 commits intoNixOS:masterfrom tobiasBora:master
matthewbauer merged 2 commits intoNixOS:masterfrom
tobiasBora:master
Conversation
GrahamcOfBorg
added
8.has: package (new)
pkgs/top-level/all-packages.nix
Outdated
| inherit (darwin.apple_sdk.frameworks) ApplicationServices; | ||
| }); | ||
|
|
||
| imapnotify = nodePackages.imapnotify; |
Member
There was a problem hiding this comment.
Can you do inherit here instead? Eventually I want to merge all of these & that makes it a little cleaner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
imapnotifyis a program, not a library, so there is no reason not to include it all-packages.nix. That way, it will be possible to search for imapnotify, while before it was hard to find it as it is a nodePackage.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)